MNT: Clean up code in SecondaryAxis#24091
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Oct 12, 2022
Merged
Conversation
QuLogic
reviewed
Oct 6, 2022
oscargus
force-pushed
the
secondaryaxescleanup
branch
from
16e6cfe to
c435e19
Compare
timhoffm
approved these changes
Oct 7, 2022
oscargus
force-pushed
the
secondaryaxescleanup
branch
from
c435e19 to
8387676
Compare
oscargus
commented
Oct 8, 2022
QuLogic
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Not everything was checked correctly earlier. Checking also leads to simplifications of x/y checking.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).