MNT: make orphaned colorbar deprecate versus raise#24088
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Oct 6, 2022
Merged
MNT: make orphaned colorbar deprecate versus raise#24088tacaswell merged 1 commit intomatplotlib:mainfrom
tacaswell merged 1 commit intomatplotlib:mainfrom
Conversation
jklymak
added
the
Release critical
QuLogic
reviewed
Oct 3, 2022
jklymak
force-pushed
the
fix-deprecate-colorbar-orphan
branch
from
4ed5aa5 to
06ecfd4
Compare
QuLogic
changed the title
QuLogic
approved these changes
Oct 4, 2022
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Probably should fix the typo in the commit message if you make this change also.
jklymak
force-pushed
the
fix-deprecate-colorbar-orphan
branch
from
06ecfd4 to
7fb75e0
Compare
Member
|
Do we need to add or update an API change note? I'm going to go ahead and merge this to move things along and we can follow up with another PR if we need to update docs. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 6, 2022
Member
Author
|
Yes, good question - I don't think we should change the existing API note, but maybe need a new one? |
QuLogic
added a commit
that referenced
this pull request
Oct 6, 2022
…088-on-v3.6.x Backport PR #24088 on branch v3.6.x (MNT: make orphaned colorbar deprecate versus raise)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23973 where we, without warning, started raising if a colorbar's mappable had no axes. This adds a deprecation, and otherwise restores the previous behaviour.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).