X Tutup
Skip to content

Revert "Refactor handling of tick and ticklabel visibility in Axis.clear"#23834

Merged
jklymak merged 1 commit intomatplotlib:mainfrom
timhoffm:revert-code-cleanup
Sep 8, 2022
Merged

Revert "Refactor handling of tick and ticklabel visibility in Axis.clear"#23834
jklymak merged 1 commit intomatplotlib:mainfrom
timhoffm:revert-code-cleanup

Conversation

@timhoffm
Copy link
Copy Markdown
Member

@timhoffm timhoffm commented Sep 8, 2022

PR Summary

This reverts commit 2357c92. (#22587)

Reversal due to a regression #23808.

Decision on the dev call: We revert this change so that the exact code from 3.5 is still used in 3.6.
We plan to have a full discussion on what clear() should do for 3.7.

@timhoffm timhoffm added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. Maintenance labels Sep 8, 2022
@timhoffm timhoffm added this to the v3.6.0 milestone Sep 8, 2022
@jklymak jklymak merged commit f9bb816 into matplotlib:main Sep 8, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 8, 2022
timhoffm pushed a commit that referenced this pull request Sep 9, 2022
…isiblity in Axis.clear" (#23838)

Co-authored-by: Jody Klymak <jklymak@gmail.com>
@QuLogic QuLogic changed the title Revert "Refactor handling of tick and ticklabel visiblity in Axis.clear" Revert "Refactor handling of tick and ticklabel visibility in Axis.clear" Sep 19, 2022
@timhoffm timhoffm deleted the revert-code-cleanup branch July 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup