negative_linestyles kwarg in contour.py#23266
Merged
tacaswell merged 2 commits intomatplotlib:mainfrom Jun 24, 2022
Merged
Conversation
6 tasks
oscargus
reviewed
Jun 14, 2022
lib/matplotlib/contour.py
Outdated
Comment on lines
+1760
to
+1761
| negative_linestyles : None or str, optional | ||
| {'solid', 'dashed', 'dashdot', 'dotted'} |
Member
There was a problem hiding this comment.
Suggested change
| negative_linestyles : None or str, optional | |
| {'solid', 'dashed', 'dashdot', 'dotted'} | |
| negative_linestyles : {*None*, 'solid', 'dashed', 'dashdot', 'dotted'}, \ | |
| optional |
(or where ever the line should break.)
Contributor
Author
There was a problem hiding this comment.
I went ahead and made this exact change. It matches linestyles formatting... I'm not sure where I saw the formatting I initially had.
41bc9bb to
1b3b390
Compare
jklymak
approved these changes
Jun 24, 2022
Member
jklymak
left a comment
There was a problem hiding this comment.
This looks good to me, and useful.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I made the
negative_linestylesfor contours toggle-able via kwarg. The only way to toggle this currently is withrcParams.I am re-opening this issue from a fresh branch. There was some discussion in #23102.
In the attached issue, we had some discussion on whether this is a good idea or not, but I think it is worth considering. We can maintain current functionality and just apply the kwarg if it is defined. This will not break previous functionality. I wrote some tests for this, but I know they can be improved. I'm not completely certain on using baseline_images with parametrized inputs.
Please use this PR and the attached issue to discuss whether this is a good idea or not. I'm happy to take this in a different direction if there are some better ideas!
Closes #23028
Previous
With this PR
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).