DOC: recommend numpy random number generator class#23221
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Jun 8, 2022
Merged
DOC: recommend numpy random number generator class#23221timhoffm merged 1 commit intomatplotlib:mainfrom
timhoffm merged 1 commit intomatplotlib:mainfrom
Conversation
oscargus
reviewed
Jun 8, 2022
jklymak
reviewed
Jun 8, 2022
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
We don't do this much in the tests, yet. Its a pretty good first issue to go through and change most of them. People tend to read the existing tests before they will ever read this document.
timhoffm
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A very minor suggestion for the developer guide. The
Generatorclass is now numpy's recommended way of generating random numbers:https://numpy.org/doc/stable/reference/random/index.html
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).