ENH: add width_ratios and height_ratios to subplots#23191
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jun 28, 2022
Merged
ENH: add width_ratios and height_ratios to subplots#23191QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
reviewed
Jun 2, 2022
04b6ea9 to
f1a8cce
Compare
story645
reviewed
Jun 8, 2022
Member
Author
|
This is ready to go, and I'll argue its a pretty big quality of life enhancement for anyone making different-width/height plots. |
timhoffm
reviewed
Jun 10, 2022
2e60682 to
17978e7
Compare
QuLogic
reviewed
Jun 21, 2022
QuLogic
approved these changes
Jun 21, 2022
Member
Author
|
@story645 got time for a quick second look? |
Contributor
|
Sorry for being late to the party, but see also #21942 (comment). |
story645
reviewed
Jun 23, 2022
story645
reviewed
Jun 24, 2022
story645
approved these changes
Jun 24, 2022
tacaswell
reviewed
Jun 24, 2022
tacaswell
reviewed
Jun 24, 2022
tacaswell
approved these changes
Jun 24, 2022
Member
tacaswell
left a comment
There was a problem hiding this comment.
Anyone can merge on CI green.
Member
Author
|
Squashed and rebased on master so font fix should be in there... |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I'm guessing 99.9% of the use of gridspec_kws is to set the height or width ratios of axes. And it is pretty esoteric to ask people to know about gridspecs in order to access this. Here we add
width_ratiosandheight_ratiosto the subplots and subplot_mosaic calls.Previously we would do
This PR allows
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).