X Tutup
Skip to content

Support quoted strings in matplotlibrc#22589

Merged
oscargus merged 1 commit intomatplotlib:mainfrom
timhoffm:quoted-matplotlibrc
Mar 6, 2022
Merged

Support quoted strings in matplotlibrc#22589
oscargus merged 1 commit intomatplotlib:mainfrom
timhoffm:quoted-matplotlibrc

Conversation

@timhoffm
Copy link
Copy Markdown
Member

@timhoffm timhoffm commented Mar 3, 2022 •
edited
Loading

This enables using the comment character # within strings. Also it lets you write hex colors more consistently as "#FFFFFF" rather than FFFFFF (i.e. omitting the hash). We discourage the latter but keep it for backward compatibility.

Closes #19288.
Superseeds #22565.

@timhoffm timhoffm added this to the v3.6.0 milestone Mar 3, 2022
oscargus
oscargus reviewed Mar 3, 2022
View reviewed changes
@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Mar 3, 2022

I guess it's OK to not support single quotes or backslash escapes (I'm less sure wrt double quotes in the string, which seem unsupported too?), but the difference with standard python syntax should probably be explicitly noted.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 3, 2022

I am 👍🏻 on this in principle, but something seems wrong with the rcparams parsing.

@timhoffm timhoffm force-pushed the quoted-matplotlibrc branch from 88b4a0d to fc41ba4 Compare March 4, 2022 00:24
@timhoffm
Copy link
Copy Markdown
Member Author

timhoffm commented Mar 4, 2022

Ha! Edge case when the line starts with a comment. Tests should pass now.

@timhoffm
Copy link
Copy Markdown
Member Author

timhoffm commented Mar 4, 2022

I guess it's OK to not support single quotes or backslash escapes (I'm less sure wrt double quotes in the string, which seem unsupported too?), but the difference with standard python syntax should probably be explicitly noted.

I indeed plan to supporting backslash escapes soon.

@timhoffm timhoffm marked this pull request as draft March 4, 2022 07:56
@timhoffm
Support quoted strings in matplotlibrc
7c378a8 
This enables using the comment character # within strings.

Closes matplotlib#19288.
Superseeds matplotlib#22565.
@timhoffm timhoffm force-pushed the quoted-matplotlibrc branch from fc41ba4 to 7c378a8 Compare March 4, 2022 13:06
@timhoffm timhoffm marked this pull request as ready for review March 4, 2022 14:57
tacaswell
tacaswell approved these changes Mar 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not hold this on other improvements (like single quotes and escaping).

@oscargus oscargus merged commit d3cc9d7 into matplotlib:main Mar 6, 2022
@timhoffm timhoffm deleted the quoted-matplotlibrc branch March 6, 2022 13:58
@timhoffm timhoffm mentioned this pull request Mar 6, 2022
Closed
6 tasks
@yy0931 yy0931 mentioned this pull request Mar 11, 2022
Closed
@timhoffm timhoffm mentioned this pull request Mar 21, 2022
Closed
@oscargus oscargus mentioned this pull request Apr 7, 2023
Closed
@anntzer anntzer mentioned this pull request Jun 15, 2023
Closed
7 tasks
@QuLogic QuLogic mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@oscargus oscargus oscargus approved these changes

Assignees

No one assigned

Labels

topic: rcparams

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

Escape # character in matplotlibrc

4 participants

@timhoffm @anntzer @tacaswell @oscargus
X Tutup