Refactor handling of tick and ticklabel visibility in Axis.clear()#22587
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Mar 16, 2022
Merged
Refactor handling of tick and ticklabel visibility in Axis.clear()#22587QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
This is a follow-up to matplotlib#20826, which makes the exceptions from clearing more explicit.
oscargus
reviewed
Mar 6, 2022
| Reset major tick params to defaults. | ||
|
|
||
| Shared subplots pre-configure tick and label visibility. To keep this | ||
| beyond an Axis.clear() operation, we may |
Member
There was a problem hiding this comment.
Suggested change
| beyond an Axis.clear() operation, we may | |
| beyond an `Axis.clear()` operation, we may |
(Or something similar. If possible. For both methods.)
oscargus
approved these changes
Mar 6, 2022
QuLogic
approved these changes
Mar 16, 2022
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20826, which makes the exceptions from clearing more explicit.
While being a bit more verbose, this makes it more clear what is going on. Also I think having proper
_reset_*_tick_kwmethods will make patching the 3D default tick direction for #22517 (comment) easy. Something along the lines (to be tested):The test introduced in #20826 should verify that this solution is equivalent and does not break something.