fixed font prop in text elements in svg figures#22541
fixed font prop in text elements in svg figures#22541not-so-rabh wants to merge 2 commits intomatplotlib:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
I don't think this is correct, e.g. results in where the unquoted DejaVu Sans is likely wrong? (at least wrt. the spec) |
|
@not-so-rabh could you comment on @anntzer's question? |
|
Converted to draft - needs discussion and rebase |
|
The issue that @anntzer points out is real, we need to only add the un-escaped font name if the name is one of the generic names. There is also some confusion about what This line of code also was impacted by #23559 and the fix for #23492 will also touch this line. I think I see how to fix both #22528 and #23492 in one shot and in the interest of trying to squeeze these in for 3.6 am just going to do it. Thank you for your work on this @not-so-rabh , I apologize for taking this issue from under you, and I hope we hear from you again! |
|
Replaced by #23638 |
Fixes #22528