Run wheel builds on PRs when requested by a label#22235
Merged
dstansby merged 1 commit intomatplotlib:mainfrom Jan 15, 2022
Merged
Run wheel builds on PRs when requested by a label#22235dstansby merged 1 commit intomatplotlib:mainfrom
dstansby merged 1 commit intomatplotlib:mainfrom
Conversation
QuLogic
force-pushed
the
labeled-wheel
branch
from
e76d16b to
cc8bd78
Compare
tacaswell
approved these changes
Jan 15, 2022
jklymak
reviewed
Jan 15, 2022
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
I wonder if we want a prefix for this that makes it clear its private? _run cibuildwheel?
dstansby
approved these changes
Jan 15, 2022
Member
Only developers can add issues AFAIK, so I think this is fine? I added the label, and labelled this issue, just to double check it works. Looks like it does 👍 I'll merge without waiting for the wheel builds to finish, and feel free to change the colour of the label. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 15, 2022
dstansby
added a commit
that referenced
this pull request
Jan 18, 2022
…235-on-v3.5.x Backport PR #22235 on branch v3.5.x (Run wheel builds on PRs when requested by a label)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When I need to change the wheel building process, I need to push a copy to my fork's
main, and then force push that away. But we can enable this on PRs by checking for a special label, reducing this extra work.I used the "Run cibuildwheel" label, but if there's consensus for a better label name, we can use it. Then I'll actually create the label.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).