Revert backport of #21631 to v3.5.0-doc#21824
Conversation
|
The Basic usage guide backport also appears to have broken things. I have half a mind to force-push these backports away, since this isn't |
|
Oh, thats confusing. Sorry for the breakage, and of course feel free to revert what is needed. |
|
... that is even more confusing, as the back ports passed CI - I guess its not worth having a different CI for these branches, but... |
|
We do not run the link-checker as part of CI and the CI does not try to install the released version. Given that we now have a handful of git-related checks on GHA, I suspect would could set up a check that asserts nothing in the lib or src directories are changed on |
|
I'm mixed on force-pushing to On the other hand, there is no reason to keep commits + their reversions around, this is not I'm pretty 50/50 on this and am OK with either option. |
|
Fixing the usage guide is less work than I thought (only one line), but now I see other stuff was merged, so I'll need to check that that is okay. |
This PR renames a tutorial, and thus needs to updtae a link in a .py file. Changes to .py files have no effect on the -doc branch, because it is run against the released version, so this breaks the build since the old link is gone. This reverts commit 37131e9.
PR Summary
This PR renames a tutorial, and thus needs to update a link in a
.pyfile. Changes to.pyfiles have no effect on the -doc branch, because it is run against the released version, so this breaks the build since the old link is gone.This reverts commit 37131e9.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).