MNT: Rename callbacksSM to callbacks#20799
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Aug 9, 2021
Merged
Conversation
greglucas
force-pushed
the
rename-callbacksSM
branch
from
5117102 to
94cc170
Compare
timhoffm
approved these changes
Aug 7, 2021
This makes the code more consistent throughout with objects having a `callbacks` attribute, rather than associating a name with them on the end.
greglucas
force-pushed
the
rename-callbacksSM
branch
from
94cc170 to
5a4c8db
Compare
QuLogic
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This makes the code more consistent throughout with objects having a
callbacksattribute, rather than associating a name with them on the end and using camelCase.First noticed by @timhoffm in #19553 (comment)
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).