Bugfix Tk start_event_loop#19959
Merged
timhoffm merged 5 commits intomatplotlib:masterfrom May 2, 2021
Merged
Conversation
QuLogic
reviewed
Apr 29, 2021
QuLogic
approved these changes
Apr 30, 2021
timhoffm
approved these changes
May 2, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 2, 2021
timhoffm
added a commit
that referenced
this pull request
May 2, 2021
…959-on-v3.4.x Backport PR #19959 on branch v3.4.x (Bugfix Tk start_event_loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #19940. With these changes, the example script in that issue no longer has the
afterrelated stderr spam. No automated tests because the bug arises in a nested interactive event loop which is not a generally supported situation I think.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).