Remove scalarmappable private update attributes#19552
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Mar 23, 2021
Merged
Remove scalarmappable private update attributes#19552QuLogic merged 1 commit intomatplotlib:masterfrom
QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
QuLogic
reviewed
Mar 2, 2021
greglucas
force-pushed
the
mesh-norm-update
branch
2 times, most recently
from
93876e9 to
bead92b
Compare
5 tasks
efiring
approved these changes
Mar 20, 2021
The updates to scalar mappable would only take effect if the array was updated. This meant that updating the vmin/vmax of the sm's norm would not be propagated to the drawn artists. This update removes the update checks from scalar mappable to calculate the colors regardless of updates to the array.
greglucas
force-pushed
the
mesh-norm-update
branch
from
bead92b to
ed6d92b
Compare
QuLogic
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The updates to scalar mappable would only occur if the
array was updated. This meant that updating the vmin/vmax of
the sm's norm would not be propagated to the drawn artists. This
update removes the array update checks from scalar mappable to calculate
the colors regardless of updates to the array.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).