Proof of concept images with units#19481
Closed
dstansby wants to merge 1 commit intomatplotlib:masterfrom
Closed
Conversation
jklymak
reviewed
Feb 8, 2021
| self.mappable = mappable | ||
| _add_disjoint_kwargs(kwargs, cmap=mappable.cmap, norm=mappable.norm) | ||
|
|
||
| # Set the formatter if |
Member
There was a problem hiding this comment.
See #18900 for changes in how the formatter and locator will work in 3.5
Member
Author
|
Thanks for bringing #18900 to my attention. With the context of that and the CZI grant, I think it's probably worth closing this (currently) bare bones attempt to wait for colorbar refactoring and a bit more thought. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #19476
There is likely lots to iron out, and many tests and documentation that would need adding, but I thought I would open this as a proof of concept for images (or more generally mappables) with units. Things that come to mind are:
axisargument, I'm not sure what to do about this when we have a mappable and not an axismunits.registry.get_converterexpects a 1D sequence as input, not 2D, there's probably a way to modify this thoughThis allows things like this image, where the correct formatter is automatically set on the colorbar: