Conversation
- QPainter.drawLine is now picky about float vs int - be more careful that we close the Qpainter out
No need for map when a single list comprehension will do. Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
Strange, the |
| # to be called at the end of paintEvent. | ||
| if rect is not None: | ||
| x0, y0, w, h = [pt / self._dpi_ratio for pt in rect] | ||
| x0, y0, w, h = [int(pt / self._dpi_ratio) for pt in rect] |
There was a problem hiding this comment.
Or round? c.f. #15656 (comment)
I'm not sure myself. I think I tested 15656 with round but it caused some test failures. Did not have time to investigate.
Maybe int() is good enough to fix this if we don't have the capacity to work out round vs. int.
There was a problem hiding this comment.
We have looked at moving more things to round in other places (#8265) and it also caused failures. I am inclined to stay with int here as I suspect that is what is used to be doing under the hood (it is just complaining about in now).
On the other hand, this is in drawing the zoom box so it probably doesn't really matter?
Are you okay to merge now, or still wait? |
|
I'm OK to merge, the version checking would only be to mkae the comit message more accurate. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Merge pull request matplotlib#17565 from tacaswell/fix_new_qt FIX: support Qt 5.15 Conflicts: lib/matplotlib/backends/backend_qt5.py - code was very different, int cast done differently.
…-v3.2.x Backport PR #17565: FIX: support Qt 5.15
3 participants
PR Summary
I may need to check the exact version we need this for more carefully. May be a pyqt, not Qt change.