Fix dicts unpacking for .plot#17506
Merged
tacaswell merged 5 commits intomatplotlib:masterfrom May 25, 2020
Merged
Conversation
timhoffm
reviewed
May 25, 2020
timhoffm
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
is supposed to work & then stopped working because of changes to how
.plotprocesses the data kwarg (#10928). This PR takes the dead simple approach of running the args to.plotthrough sanitize_sequence since it's a pass through function, but there's probably a better way.Also added a bunch of tests to hopefully catch this. I think this is release critical since it worked in 3.0 and broke in 3.1, but on the other hand I only noticed this 'cause I wanted to update some docs (that actually should have been fine even w/o the fix 🙃)
PR Checklist