Merged
Conversation
Contributor
|
Perhaps just set the rcParam instead? |
jklymak
force-pushed
the
doc-fix-pcolor2
branch
from
fef7639 to
e363886
Compare
Member
Author
|
I don't think there is anything wrong with being explicit here, even if we plan to change the default. I am not a particular fan of rcParams in examples because the user doesn't know what the rcParam value is. |
anntzer
approved these changes
Feb 21, 2020
Contributor
anntzer
left a comment
anntzer
left a comment
There was a problem hiding this comment.
I agree with being explicit but the examples here are more about different normalizations, not about edge/shading behavior, so I think they slightly distract on the main message. OTOH I won't insist on the change either.
Waiting for CI.
Member
|
Unfortunately needs a rebase again. |
Member
Author
|
... rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #16493
Note I've removed a bunch of "user_demo" examples. I made those back when I made the original tutorials largely because I thought I was supposed to, but I think we want to not duplicate tutorials and examples, so I have removed them.
From #16493, These remaining files are meant to have warnings emitted:
PR Checklist