Don't import rcParams but rather use mpl.rcParams.#16406
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Feb 4, 2020
Merged
Don't import rcParams but rather use mpl.rcParams.#16406timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
This helps letting modules be imported early in the init process, even before the rcParams object is constructed. I didn't change all cases, just those needed to make matplotlib.scale importable into matplotlib.colors.
Codecov Report
@@ Coverage Diff @@
## master #16406 +/- ##
==========================================
- Coverage 80.85% 80.85% -0.01%
==========================================
Files 307 307
Lines 75745 75748 +3
Branches 9690 9691 +1
==========================================
+ Hits 61245 61246 +1
- Misses 11961 11962 +1
- Partials 2539 2540 +1
Continue to review full report at Codecov.
|
jklymak
approved these changes
Feb 4, 2020
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Seems like a good start on this to me.
timhoffm
approved these changes
Feb 4, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps letting modules be imported early in the init process, even
before the rcParams object is constructed.
I didn't change all cases, just those needed to make matplotlib.scale
importable into matplotlib.colors (per #16386).
PR Summary
PR Checklist