Default to writing animation frames to a temporary directory.#16082
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Jan 4, 2020
Merged
Default to writing animation frames to a temporary directory.#16082timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
anntzer
force-pushed
the
animation-tmpdir
branch
from
5ee8428 to
2874ba0
Compare
dopplershift
approved these changes
Jan 4, 2020
(We could later deprecate clean_temp, as the user can simply pass a non-None frame_prefix to write temporary frames whereever they want and keep them there.)
anntzer
force-pushed
the
animation-tmpdir
branch
from
2874ba0 to
cc3482f
Compare
timhoffm
reviewed
Jan 4, 2020
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Not looked much into this, but it looks confusing that frame_prefix determines cleanup but clear_temp as well. Is this really necessary?
Contributor
Author
|
I plan to deprecate clear_temp later. (One can't really support frame_prefix=None (i.e. tmpdir) + clear_temp=False without adding a completely separate code path for creating a tmpdir with mkdtemp so that it doesn't get deleted, but that seems just not worth it.) |
timhoffm
approved these changes
Jan 4, 2020
6 tasks
QuLogic
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(We could later deprecate clean_temp, as the user can simply pass a
non-None frame_prefix to write temporary frames whereever they want and
keep them there.)
Redo of #3536 (see motivation there) and some of #11860, also solves #11863 (comment).
PR Summary
PR Checklist