Deprecate support for dash-offset = None.#15828
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Mar 10, 2020
Merged
Conversation
anntzer
force-pushed
the
dashoffset-none
branch
2 times, most recently
from
87e9acf to
9300485
Compare
Member
|
Could we normalize The failures look real, but did not dig into them.... |
Contributor
Author
|
The failures are real, need to look into it. |
anntzer
force-pushed
the
dashoffset-none
branch
from
9300485 to
5345d49
Compare
anntzer
force-pushed
the
dashoffset-none
branch
from
5345d49 to
5b1be65
Compare
anntzer
force-pushed
the
dashoffset-none
branch
2 times, most recently
from
838c6fc to
93f43a3
Compare
Contributor
Author
|
figured out the failure, now fixed, should be good to go. |
timhoffm
approved these changes
Jan 26, 2020
QuLogic
approved these changes
Mar 10, 2020
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Rebase and maybe small tweak to a sentence.
e.g. `plot([1, 2], ls=(None, (4, 4)))` which was previously a synonym for `plot([1, 2], ls=(0, (4, 4)))` which means "dash-pattern of 4pt-long dashes separated by 4pt spaces, with an offset of 0pt at start". Passing None instead of 0 was already not (likely, never) supported for pdf, ps, or svg (an exception is raised at savefig() time for ps/svg, an invalid pdf is generated). There isn't much of a point in supporting None (this also makes e.g. mplcairo more complex because of static typing in C++ extensions), so just deprecate it.
anntzer
force-pushed
the
dashoffset-none
branch
from
93f43a3 to
eb76378
Compare
Contributor
Author
|
edited accordingly, and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
e.g.
plot([1, 2], ls=(None, (4, 4)))which was previously a synonymfor
plot([1, 2], ls=(0, (4, 4)))which means "dash-pattern of4pt-long dashes separated by 4pt spaces, with an offset of 0pt at
start".
Passing None instead of 0 was already not (likely, never) supported for
pdf, ps, or svg (an exception is raised at savefig() time for ps/svg, an
invalid pdf is generated). There isn't much of a point in supporting
None (this also makes e.g. mplcairo more complex because of static
typing in C++ extensions), so just deprecate it.
Goes on top of #15827.
Edit: closes #14996, which is basically the issue described here.
PR Checklist