Add note to hist docstring about speed#15375
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Nov 9, 2019
Merged
Conversation
tacaswell
reviewed
Oct 4, 2019
timhoffm
reviewed
Oct 4, 2019
timhoffm
reviewed
Oct 22, 2019
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
When, you‘re done, please squash your changes into a single commit to keep the history clean.
Perseudonymous
force-pushed
the
note_hist_speed
branch
from
f20b6d7 to
2526b4d
Compare
timhoffm
approved these changes
Nov 9, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add note to hist docstring stating that using
histtype='bar'can be slow when using a large number of bins. I have used the wording proposed here: https://github.com/matplotlib/matplotlib/pull/12493/commits. As #12493 involves adding a new rcparam and has had no comments for almost a year I have made this a separate pull request in order to resolve the discussions in #7121.PR Checklist