When no gui event loop is running, propagate callback exceptions.#15270
Merged
dstansby merged 3 commits intomatplotlib:masterfrom Oct 20, 2019
Merged
When no gui event loop is running, propagate callback exceptions.#15270dstansby merged 3 commits intomatplotlib:masterfrom
dstansby merged 3 commits intomatplotlib:masterfrom
Conversation
anntzer
force-pushed
the
cbr-exceptions
branch
2 times, most recently
from
f3ecbd0 to
5cd9481
Compare
jklymak
approved these changes
Oct 8, 2019
efiring
approved these changes
Oct 8, 2019
Member
efiring
left a comment
efiring
left a comment
There was a problem hiding this comment.
Looks good, subject to passing test after rebase.
anntzer
force-pushed
the
cbr-exceptions
branch
from
5cd9481 to
8a7f38a
Compare
Contributor
Author
|
rebased |
anntzer
force-pushed
the
cbr-exceptions
branch
2 times, most recently
from
7ae415a to
c476c4d
Compare
timhoffm
reviewed
Oct 11, 2019
anntzer
force-pushed
the
cbr-exceptions
branch
from
c476c4d to
34998a5
Compare
CallbackRegistry currently defaults to suppressing exceptions that occur in callbacks because they cause PyQt5 to abort() the program with no chance of even catching the exception, but such a behavior is annoying when writing tests involving callbacks (e.g., mplcursors), because in that case we actually want to see whether an exception occurred, and typically fail the test in that case. Instead we can detect whether a GUI event loop is currently running and propagate the exception if none is running. Part of the patch is just moving `_get_running_interactive_framework` from `backends` to `cbook`, so that `cbook` keeps its property of being importable independent of the rest of mpl.
anntzer
force-pushed
the
cbr-exceptions
branch
from
34998a5 to
084d79b
Compare
Member
|
The drop in test coverage was due to there being a dead branch in the test code now that the default case is now in it's own test. |
tacaswell
approved these changes
Oct 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackRegistry currently defaults to suppressing exceptions that occur
in callbacks (since #9063) because they cause PyQt5 to abort() the program with no
chance of even catching the exception, but such a behavior is annoying
when writing tests involving callbacks (e.g., mplcursors), because in
that case we actually want to see whether an exception occurred, and
typically fail the test in that case.
Instead we can detect whether a GUI event loop is currently running and
propagate the exception if none is running.
Part of the patch is just moving
_get_running_interactive_frameworkfrom
backendstocbook, so thatcbookkeeps its property of beingimportable independent of the rest of mpl.
PR Summary
PR Checklist