Fix ScalarFormatter formatting of masked values#15140
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom Aug 28, 2019
Merged
Fix ScalarFormatter formatting of masked values#15140tacaswell merged 2 commits intomatplotlib:masterfrom
tacaswell merged 2 commits intomatplotlib:masterfrom
Conversation
Member
|
I think the case where the array itself contains |
Member
|
I don't think an API change note is needed. This simply fixes the bug introduced in #12459. |
anntzer
approved these changes
Aug 27, 2019
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
dstansby
pushed a commit
to dstansby/matplotlib
that referenced
this pull request
Sep 4, 2019
FIX: ScalarFormatter formatting of masked values
tacaswell
added a commit
that referenced
this pull request
Sep 4, 2019
Backport PR #15140 on branch v3.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15103. Could probably do with a test. Possibly an API change since previously a masked value would be formatted as
nan?