FIX: allow secondary axes minor locators to be set#14447
Merged
anntzer merged 2 commits intomatplotlib:masterfrom Jun 20, 2019
Merged
FIX: allow secondary axes minor locators to be set#14447anntzer merged 2 commits intomatplotlib:masterfrom
anntzer merged 2 commits intomatplotlib:masterfrom
Conversation
timhoffm
approved these changes
Jun 4, 2019
tacaswell
reviewed
Jun 8, 2019
| if self._orientation == 'y': | ||
| pscale = self._parent.yaxis.get_scale() | ||
| set_scale = self.set_yscale | ||
| if pscale == self._parentscale: |
Contributor
There was a problem hiding this comment.
It's ==, get_scale returns a string. Well really we should retrieve the scale object rather than a scale string, but that's a separate issue...
tacaswell
approved these changes
Jun 8, 2019
Member
tacaswell
left a comment
There was a problem hiding this comment.
One minor comment, but otherwise 👍
Member
Contributor
|
Merging as 3.2, but @jklymak can backport to 3.1 if he wants :) |
anntzer
approved these changes
Jun 20, 2019
6 tasks
This was referenced Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We set the scale for
secondary_axisfor each draw in case the parent scale has changed (i.e. from linear to log), but this means that we can't set the locators and formatters for the secondary axis. This change keeps track of the parent scale and only resets the locators and formatters if the parent scale changes.Closes #14443
now works as expected...
PR Checklist