Remove logic for optionally building Agg and TkAgg.#13075
Remove logic for optionally building Agg and TkAgg.#13075QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
anntzer
force-pushed
the
force-agg-tkagg
branch
2 times, most recently
from
2b3ba13 to
d6aaaee
Compare
|
Would it be better to actually make tkagg optional? |
|
It's been non-optional for years and no one complained; what would be the use case? Note that the build doesn't depend on any external headers or libraries. |
|
(In fact I'm tempted to also make the OSX backend non-optional if someone can verify whether the cocoa headers are always installed with xcode...) |
anntzer
force-pushed
the
force-agg-tkagg
branch
from
d6aaaee to
07e4259
Compare
anntzer
force-pushed
the
force-agg-tkagg
branch
from
07e4259 to
d965971
Compare
|
punting to 3.2 as it has conflicts, in non-critical, and the fiddly to make sure we got it right. |
anntzer
force-pushed
the
force-agg-tkagg
branch
from
d965971 to
be1a25b
Compare
|
Rebased. Once again, note that always forcing the build of tkagg (which does not depend on the tk headers) has been the actual behavior for years now. |
anntzer
force-pushed
the
force-agg-tkagg
branch
from
0bf9e36 to
9d7f88e
Compare
|
It seems that moving Travis means I can't restart the broken build, so you'll have to rebase. |
They are actually not optional (that's the `force = True` setting which overrides the OptionalBackendPackage logic), so just make them SetupPackages and remove the corresponding (outdated) comments in setup.cfg.template.
anntzer
force-pushed
the
force-agg-tkagg
branch
from
9d7f88e to
babe80b
Compare
|
rebased, build passes |
|
I remember something about someone having problems building matplotlib
against a python that didn't have Tk. Could that be the reason why the code
is this way for TkAgg?
…On Mon, Nov 4, 2019 at 6:14 AM Antony Lee ***@***.***> wrote:
rebased
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13075?email_source=notifications&email_token=AACHF6AW6OQXK4TQPDXGX3LQR772LA5CNFSM4GMYHJJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC64ZAA#issuecomment-549309568>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHF6B3TLBCYRFOLV4JC63QR772LANCNFSM4GMYHJJQ>
.
|
|
The tkagg build doesn't interact with tk at build time whatsoever since #6442. Quoting from that PR:
|
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Seem reasonable. Should we want optional Agg at some point, we can always reintroduce it. For now this is a simplification of the setup code.
5 participants
PR Summary
They are actually not optional (that's the
force = Truesetting whichoverrides the OptionalBackendPackage logic), so just make them
SetupPackages and remove the corresponding (outdated) comments in
setup.cfg.template.
Builds on top of #13074 as the prose in setup.cfg.template is only true if we also remove windowing from there. [edit: that PR has been merged]
(The OptionalBackendPackage logic was also previously useful back when the default backend was selected at build time, but that's no longer the case.)
PR Checklist