X Tutup
Skip to content

Fail-fast when trying to run tests with too-old pytest.#12975

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:pytest-version
Dec 11, 2018
Merged

Fail-fast when trying to run tests with too-old pytest.#12975
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:pytest-version

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Dec 10, 2018

Otherwise the error message can be quite obscure.

e.g. #12945 (comment)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Dec 10, 2018
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Dec 10, 2018

We should set minversion in pytest.ini.

Otherwise the error message can be quite obscure.
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Dec 10, 2018

Ah, that's much better, thanks for pointing it out.

@tacaswell tacaswell merged commit 7157312 into matplotlib:master Dec 11, 2018
@anntzer anntzer deleted the pytest-version branch December 11, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup