Pin pytest to <3.8 (for 2.2.x)#12879
Merged
tacaswell merged 1 commit intomatplotlib:v2.2.xfrom Dec 17, 2018
Merged
Conversation
timhoffm
force-pushed
the
fix-pytest-error-in-ci-2.2.x
branch
from
cd27324 to
d7e3789
Compare
jklymak
approved these changes
Nov 26, 2018
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Looks good - I think the macosx failure was unrelated, but OTOH there are some changes to pytet-rerunfailures that I don't fully understand; why are those there?
Member
Author
|
The changes to |
Member
|
Hmm, but the OSX tests aren't passing. Looks lie something w/ homebrew though, and not this PR? |
Member
Author
|
Yes. I‘m not an OSX expert, but I‘m quite sure the failure is unrelated to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #12825 for 2.2.x (CI failure due to pytest warnings).
3.0.x is handled separately in #12878.
This limits
pytest<3.8because 3.8 starts issueing warnings that we do not want to fix in the 2.2.x code.pytest-rerunfailures<5for the py27 build because that build usespytest==3.1and the newpytest-rerunfailures==5requirespytest>=3.6.