Fix some warnings from Travis#12316
Merged
dstansby merged 6 commits intomatplotlib:masterfrom Sep 29, 2018
Merged
Conversation
Member
Author
|
Looks like a lot more are triggered in AppVeyor. I will try to get to those later today. |
QuLogic
force-pushed
the
travis-warnings
branch
2 times, most recently
from
7877939 to
8942b07
Compare
Member
Author
|
Managed to fix up a few more sets, from AppVeyor and macOS, due to missing dependencies triggering warnings in the checks. |
Using pytest.param(..., marks=pytest.mark.something) is a different type than if using pytest.mark.something(...), so we need to handle that case on skipping extensions.
QuLogic
force-pushed
the
travis-warnings
branch
from
5beec56 to
d82d0f7
Compare
dstansby
approved these changes
Sep 29, 2018
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Thanks for catching the other parameterise fixes!
Member
|
@meesekesdev backport to v3.0.x |
Member
Author
|
Note that since this would use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
These are pretty much deprecated items in our dependencies. Slightly related to #12297.
PR Checklist