X Tutup
Skip to content

Remove some pytest parameterising warnings#12297

Merged
jklymak merged 1 commit intomatplotlib:masterfrom
dstansby:param-pytest
Sep 26, 2018
Merged

Remove some pytest parameterising warnings#12297
jklymak merged 1 commit intomatplotlib:masterfrom
dstansby:param-pytest

Conversation

@dstansby
Copy link
Copy Markdown
Member

@dstansby dstansby commented Sep 26, 2018

Removes a bunch of warnings that look like

lib/mpl_toolkits/tests/test_mplot3d.py:129: RemovedInPytest4Warning: Applying marks directly to parameters is deprecated, please use pytest.param(..., marks=...) instead.
For more details, see: https://docs.pytest.org/en/latest/parametrize.html
  @image_comparison(baseline_images=['mixedsubplot'], remove_text=True,

@dstansby dstansby changed the title [WIP] Remove some pytest parameterising warnings Remove some pytest parameterising warnings Sep 26, 2018
@jklymak jklymak merged commit 47bfac4 into matplotlib:master Sep 26, 2018
@dstansby dstansby deleted the param-pytest branch September 26, 2018 16:09
@dstansby dstansby added this to the v3.1 milestone Sep 26, 2018
@QuLogic QuLogic mentioned this pull request Sep 27, 2018
2 tasks
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Sep 29, 2018

@meeseeksdev backport to v3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 29, 2018
@dstansby dstansby modified the milestones: v3.1, v3.0.x Sep 29, 2018
dstansby added a commit that referenced this pull request Sep 29, 2018
…297-on-v3.0.x

Backport PR #12297 on branch v3.0.x (Remove some pytest parameterising warnings)
@ArchangeGabriel
Copy link
Copy Markdown
Contributor

@meeseeksdev backport to v2.2.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Jan 16, 2019

Awww, sorry ArchangeGabriel you do not seem to be allowed to do that, please ask a repository maintainer.

@ArchangeGabriel
Copy link
Copy Markdown
Contributor

ArchangeGabriel commented Jan 16, 2019

OK, that was just to get the instructions as in #12154 (comment).

(EDIT: Figured them myself)

@tacaswell
Copy link
Copy Markdown
Member

Thanks for digging into and getting these pytest issues fixed on the 2.2.x branch @ArchangeGabriel !

QuLogic added a commit that referenced this pull request Jan 22, 2019
…154-on-v2.2.x

Backport PRs #12154, #12294, #12297, #12316, #13159 & #13205 to fix multiple tests issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup