Fix expand_dims warnings in triinterpolate#12294
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Sep 26, 2018
Merged
Conversation
ImportanceOfBeingErnest
approved these changes
Sep 26, 2018
Member
ImportanceOfBeingErnest
left a comment
ImportanceOfBeingErnest
left a comment
There was a problem hiding this comment.
Judging from the numpy documentation as well as the fact that there is no difference in output of the CubicTriInterpolator, this is the correct thing to do.
QuLogic
approved these changes
Sep 26, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 26, 2018
QuLogic
added a commit
that referenced
this pull request
Sep 27, 2018
…294-on-v3.0.x Backport PR #12294 on branch v3.0.x (Fix expand_dims warnings in triinterpolate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.expand_dimsis meant to take the axis after which a new dimension is to be inserted, so the3just needed changed to2for the bottom block. (see the note at https://docs.scipy.org/doc/numpy/reference/generated/numpy.expand_dims.html)This was causing lots of test warnings like