Merged
Conversation
lines_bars_and_markers/barchart and the first half of statistics/barchart_demo are basically the same examples with some additional labeling on the former. Move the additional features of the former to the latter.
anntzer
force-pushed
the
merge-barchart-examples
branch
from
b3bdc08 to
5608ac3
Compare
jklymak
approved these changes
Oct 2, 2018
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
What is the policy abotu removing examples? Do we just let them go away or do we redirect them somewhere? If someone linked the canonical barchart.html would they get 404 on the new version of the docs?
Contributor
Author
|
There's no redirection right now. I think we should redirect matplotlib.org/gallery/... to matplotlib.org/$version/gallery/... (which is what cpython does) so that people don't bookmark links that will be broken in the future, but that's a wholly separate issue... |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lines_bars_and_markers/barchart and the first half of
statistics/barchart_demo are basically the same examples with some
additional labeling on the former. Move the additional features of the
former to the latter.
PR Summary
PR Checklist