Merged
Conversation
This was referenced Jun 14, 2018
afvincent
reviewed
Jun 14, 2018
lib/matplotlib/markers.py
Outdated
| Also see the :doc:`/gallery/text_labels_and_annotations/stix_fonts_demo`. | ||
|
|
||
| Integer numbers from ``0`` to ``11`` create lines and triangles. Those are | ||
| equally accessible via capitalied variables, like ``CARETDOWNBASE``. |
choldgraf
approved these changes
Jun 14, 2018
0db1b0b to
0b6942b
Compare
0b6942b to
354fa7d
Compare
Member
Author
|
Not sure what the problem of travis-ci is; it looks like it doesn't like itself rather than not liking this PR. |
Contributor
|
I gave it a restart to see if that fixes things |
Member
Author
|
It didn't. Something is generally going wrong with the ci tests currently, other PRs are affected by the same issue. |
Member
|
Merged; I don't think the CI problems are here... |
Contributor
|
🎉 |
afvincent
reviewed
Jun 29, 2018
| ``"H"`` |m16| hexagon2 | ||
| ``"+"`` |m17| plus | ||
| ``"x"`` |m18| x | ||
| ``"X"`` |m21| x (filled) |
Contributor
There was a problem hiding this comment.
@ImportanceOfBeingErnest
This should have been |m24| rather than |m21|, right?
Look for example for "x_filled" in the output of the following script, adapted from yours:
from matplotlib.lines import Line2D
markers= dict((k,v) for k,v in Line2D.markers.items())
markers.update({"$f$" : "mathtext"})
for i, (k, v) in enumerate(markers.items()):
if v=="nothing":
continue
print("{:02d}".format(i), k, v)
Member
Author
There was a problem hiding this comment.
Absolutely. Thanks for spotting this. It should be fixed by #11545.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #7342 and closes #8556.
#7342 lists a few things to improve about the
matplotlib.markersdocumenation.This PR fixes those. In particular it
The marker table will look like
For completeness/reproducibility, here is the code to produce the images:
PR Checklist