textpath tries the adobe standard encoding as a default for fonts#112
Merged
efiring merged 1 commit intomatplotlib:masterfrom Jul 7, 2011
Merged
textpath tries the adobe standard encoding as a default for fonts#112efiring merged 1 commit intomatplotlib:masterfrom
efiring merged 1 commit intomatplotlib:masterfrom
Conversation
Member
|
I think @jkseppan is probably the best person to review this. |
Member
|
Sorry for the slow reaction. The patch looks fine to me, although I am no expert in Freetype. Since it seems that a lot of the font-related code must be written by trial and error in the absence of good documentation, I would like there to be test cases for each successive improvement. How difficult would it be to write a test case from the "field" example? I think we already ship some TeX fonts, so we could use one of them and get pretty repeatable output. But I'm fine with merging this as-is. |
efiring
added a commit
that referenced
this pull request
Jul 7, 2011
textpath tries the adobe standard encoding as a default for fonts
Member
|
The test idea is good, but I think it is best not to let it hold up the merge of the present change. If anyone is inspired to add a test, it can be done at any time. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the textpath module was not able to handle glyphs like "fi", "fl" and etc for TeX text.
For example,
rcParams["text.usetex"]=True
t = text(0.5, 0.5, "field", size=50)
from matplotlib.patheffects import withStroke
t.set_path_effects([withStroke(foreground="red", linewidth=5)])
and "fi" is not displayed.
The patch tries to convert the glyph id reported by the dviread module to the proper glyph id for the font to be used using the encoding information.
By the way, I'm hardly an expert on this subject and I hope some one more knowledgeable than me review the patch and see if I get this right.
-JJ