Allow filtering by window roles#893
Merged
PapyElGringo merged 5 commits intomaterial-shell:mainfrom Oct 5, 2022
Merged
Conversation
HalfVoxel
approved these changes
Oct 5, 2022
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Collaborator
|
Thanks both of you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started using fig and noticed some issues where material-shell would create a full window for the autocomplete popup. The suggested solution for WMs is to filter the window by its role (
autocompletein this case), but material-shell doesn't allow filtering by window role, so this PR adds that.The only issue here is that I'm not sure what's a good way to discover the window roles as it doesn't seem like gnome inspector gives those details.