Merged
Conversation
Contributor
|
Works for me on Gnome 43, at least as far as I can test it. The error message that was previously printed in the logs doesn’t show anymore, but I cannot not confirm whether a notification is actually displayed the way it is intended. |
HalfVoxel
requested changes
Sep 28, 2022
Closed
HalfVoxel
requested changes
Oct 5, 2022
| if (mainChild instanceof (compareVersions(gnomeVersionNumber, parseVersion('43.0')) >= 0 ? panel.QuickSettings : panel.AggregateMenu)) { | ||
| if ( | ||
| mainChild instanceof | ||
| (compareVersions(gnomeVersionNumber, parseVersion('43.0')) >= 0 |
Contributor
There was a problem hiding this comment.
I'd prefer this check to be stored in a const variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.