fix(editor): Korean IME auto-pair behavior#12432
Open
80ROkWOC4j wants to merge 1 commit intologseq:version/filefrom
Open
fix(editor): Korean IME auto-pair behavior#1243280ROkWOC4j wants to merge 1 commit intologseq:version/filefrom
80ROkWOC4j wants to merge 1 commit intologseq:version/filefrom
Conversation
|
|
80ROkWOC4j
force-pushed
the
version/file/260228_ime_auto_pair
branch
from
dbb34c0 to
2df9a11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr fixes #12418 in file version.
Changes
editor.cljs: Add IME status snapshot.editor_test.cljs: Add IME related tests.Why bunch of codes
This fix became larger because the bug was caused by IME event ordering, not by a single missing condition.
With Korean IME,
compositionend,keyup, and DOM updates do not arrive in the same order as normal keydown-based input, and some engines expose the key asProcess/229or omit it. That means the existing autopair logic cannot infer enough from the current DOM alone.The snapshot and IME-specific state were added to recover the pre-commit editor state and keep IME behavior aligned with the existing non-IME autopair behavior, instead of introducing a separate autopair implementation.
Tested Env
Windows 11, Edge & Firefox browser