X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Events: improve Store IAM Statement typing#13716

Merged
bentsku merged 1 commit intomainfrom
fix-event-typing
Feb 9, 2026
Merged

Events: improve Store IAM Statement typing#13716
bentsku merged 1 commit intomainfrom
fix-event-typing

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 6, 2026

Motivation

Follow up from #13689, some typing was still wrong around IAM policy, their format can be pretty fluid: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_statement.html

Changes

  • update typing of Statement in events store

Tests

Related

@bentsku bentsku added this to the 4.14 milestone Feb 6, 2026
@bentsku bentsku self-assigned this Feb 6, 2026
@bentsku bentsku added aws:events Amazon EventBridge semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 6, 2026
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 9s ⏱️ -13s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 0f59883. ± Comparison against base commit 20cc1b3.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 0f59883. ± Comparison against base commit 20cc1b3.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results - Alternative Providers

407 tests   274 ✅  3m 30s ⏱️
  1 suites  133 💤
  1 files      0 ❌

Results for commit 0f59883.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 29m 17s ⏱️
2 917 tests 2 798 ✅ 119 💤 0 ❌
2 923 runs  2 798 ✅ 125 💤 0 ❌

Results for commit 0f59883.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 1m 38s ⏱️ - 58m 48s
2 893 tests  - 2 305  2 771 ✅  - 2 076  122 💤  - 229  0 ❌ ±0 
2 895 runs   - 2 305  2 771 ✅  - 2 076  124 💤  - 229  0 ❌ ±0 

Results for commit 0f59883. ± Comparison against base commit 20cc1b3.

This pull request removes 2305 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@bentsku bentsku marked this pull request as ready for review February 6, 2026 22:18
@bentsku bentsku requested a review from maxhoheiser as a code owner February 6, 2026 22:18
@bentsku bentsku requested a review from giograno February 6, 2026 22:18
@bentsku bentsku merged commit acb7eee into main Feb 9, 2026
59 checks passed
@bentsku bentsku deleted the fix-event-typing branch February 9, 2026 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser

1 more reviewer

@giograno giograno giograno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bentsku bentsku

Labels

aws:events Amazon EventBridge docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

2 participants

@bentsku @giograno
X Tutup