X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

SNS: add missing requires_in_process test markers#13703

Merged
bentsku merged 1 commit intomainfrom
fix-sns-markers
Feb 5, 2026
Merged

SNS: add missing requires_in_process test markers#13703
bentsku merged 1 commit intomainfrom
fix-sns-markers

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 5, 2026

Motivation

In a k8s test run, realized we were missing those markers as they access SNS state in process.

Changes

  • add skip markers to the 3 failing tests

Tests

Related

@bentsku bentsku added this to the 4.14 milestone Feb 5, 2026
@bentsku bentsku self-assigned this Feb 5, 2026
@bentsku bentsku requested a review from baermat as a code owner February 5, 2026 12:38
@bentsku bentsku added aws:sns Amazon Simple Notification Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 5, 2026
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being on top of it!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 58s ⏱️ +20s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a49762f. ± Comparison against base commit 3a3586b.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a49762f. ± Comparison against base commit 3a3586b.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 31m 27s ⏱️
3 156 tests 3 032 ✅ 124 💤 0 ❌
3 168 runs  3 038 ✅ 130 💤 0 ❌

Results for commit a49762f.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

LocalStack Community integration with Pro

    2 files      2 suites   1h 4m 10s ⏱️
3 135 tests 3 008 ✅ 127 💤 0 ❌
3 140 runs  3 011 ✅ 129 💤 0 ❌

Results for commit a49762f.

@bentsku bentsku merged commit 15bf596 into main Feb 5, 2026
58 checks passed
@bentsku bentsku deleted the fix-sns-markers branch February 5, 2026 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

aws:sns Amazon Simple Notification Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup