X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Deprecate TaggingService#13697

Merged
viren-nadkarni merged 1 commit intomainfrom
deprecate-tagging-service
Feb 5, 2026
Merged

Deprecate TaggingService#13697
viren-nadkarni merged 1 commit intomainfrom
deprecate-tagging-service

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Feb 4, 2026

Changes

This PR adds a deprecation warning to the TaggingService which highlights its use in static type checkers.

image

This change solely targets developers. End user UX is not affected.

@viren-nadkarni viren-nadkarni self-assigned this Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 16s ⏱️ -9s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9ddf48f. ± Comparison against base commit 13ed487.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 58s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9ddf48f. ± Comparison against base commit 13ed487.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 38m 53s ⏱️
5 610 tests 5 048 ✅ 561 💤 1 ❌
5 616 runs  5 048 ✅ 567 💤 1 ❌

For more details on these failures, see this check.

Results for commit c6d18c1.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 58m 51s ⏱️ -42s
5 189 tests ±0  4 798 ✅ ±0  391 💤 ±0  0 ❌ ±0 
5 191 runs  ±0  4 798 ✅ ±0  393 💤 ±0  0 ❌ ±0 

Results for commit c6d18c1. ± Comparison against base commit 26619a9.

@viren-nadkarni viren-nadkarni force-pushed the deprecate-tagging-service branch from c6d18c1 to 9ddf48f Compare February 5, 2026 09:39
@viren-nadkarni viren-nadkarni marked this pull request as ready for review February 5, 2026 09:40
Copy link
Collaborator

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

Copy link
Contributor

@aidehn aidehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't actually know how to do this but it's nice to know it's just a decorator!

Small nit that not all services will use the RGTAPlugin system since not all services are supported by it, but all services should be using the Tagger functionality which might be better for the message here!

@viren-nadkarni viren-nadkarni force-pushed the deprecate-tagging-service branch from 9ddf48f to 0145049 Compare February 5, 2026 10:30
@viren-nadkarni viren-nadkarni merged commit 3bd884b into main Feb 5, 2026
5 checks passed
@viren-nadkarni viren-nadkarni deleted the deprecate-tagging-service branch February 5, 2026 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup