This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Follow-up for ruff target-version upgrade#13696
Merged
Conversation
giograno
added
the
semver: patch
giograno
added
review: merge when ready
alexrashed
approved these changes
Feb 4, 2026
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on this so fast! It really is annoying how brittle this is currently, but this will soon be fixed with @silv-io finally extracting the CLI to its own repo! 🤩
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 37m 38s ⏱️ Results for commit 1ced20d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With #13688 we upgraded the target version of
ruffto Python 3.13.Therefore, we upgraded some
Genericsyntax. Unfortunately,localstack.aws.connectis imported from thebootstrapmodule in Pro. This led to failures in the CLI tests.Changes
localstack.aws.connect.Tests
Related