This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Events: improve typing of models and default values#13689
Merged
Conversation
bentsku
added
aws:events
Test Results - Alternative Providers407 tests 274 ✅ 3m 47s ⏱️ Results for commit c0216d3. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 28m 43s ⏱️ Results for commit c0216d3. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 2m 53s ⏱️ Results for commit c0216d3. ♻️ This comment has been updated with latest results. |
giograno
approved these changes
Feb 4, 2026
Member
giograno
left a comment
giograno
left a comment
There was a problem hiding this comment.
Looks good, thanks 👍 You've got a small conflict to fix (sorry for that).
bentsku
force-pushed
the
events-store-avro
branch
from
809443c to
c0216d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR reworks the
eventsstore models to be more in line with reality, using default values when necessary, and fixing the init steps for datetime objects.One small issue is that those datetime might not be exactly the same, but I guess that's one of the issue of using data classes.
Changes
eventsstoreTests
Related