This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
giograno
added
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 7s ⏱️ Results for commit 5e0ea6f. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers992 tests 596 ✅ 21m 39s ⏱️ Results for commit 5e0ea6f. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 38m 32s ⏱️ Results for commit 5e0ea6f. ♻️ This comment has been updated with latest results. |
giograno
requested review from
baermat,
bentsku,
dfangl,
dominikschubert,
gregfurman,
joe4dev,
k-a-il,
maxhoheiser,
thrau and
tiurin
as code owners
giograno
requested review from
alexrashed,
pinzon,
silv-io,
simonrw and
viren-nadkarni
as code owners
giograno
removed request for
baermat,
bentsku,
dfangl,
dominikschubert,
gregfurman,
joe4dev,
k-a-il,
maxhoheiser,
pinzon,
silv-io,
simonrw,
tiurin and
viren-nadkarni
alexrashed
approved these changes
Feb 4, 2026
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Good catch and nice cleanup! 🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While making
InterruptiblePriorityQueuegeneric (see #13684), I was using the newer Python 3.12 syntax, and I was getting linting errors. Therefore, I noticed thatruffpoints to311as the target version, which does not match.python-version.Changes
rufftarget version to313.