X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

SNS:v2 return pending confirmation on list subs#13666

Merged
baermat merged 3 commits intomainfrom
sns/list-subs-pending
Feb 3, 2026
Merged

SNS:v2 return pending confirmation on list subs#13666
baermat merged 3 commits intomainfrom
sns/list-subs-pending

Conversation

@baermat
Copy link
Member

@baermat baermat commented Jan 30, 2026

Motivation

This PR ensures that in our v2 implementation subscriptions that are pending confirmation are returning the proper response when listing subscriptions

closes PNX-376

Changes

  • returns "PendingConfirmation" on list_subscriptions as sub_arn if the sub has not been confirmed yet

Tests

Related

@baermat baermat added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 088 tests  +4   21 229 ✅ +4   6m 20s ⏱️ -16s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 276cd15. ± Comparison against base commit 582c9e8.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
tests.unit.test_common.TestCommon ‑ test_cleanup_threads_and_processes_calls_shutdown_hooks

tests.unit.utils.test_threads.TestThreads ‑ test_cleanup_threads_and_processes_calls_shutdown_hooks
tests.unit.utils.test_threads.TestThreads.TestStartThread ‑ test_start_thread_returns_a_func_thread
tests.unit.utils.test_threads.TestThreads.TestStartThread ‑ test_start_thread_with_custom_name
tests.unit.utils.test_threads.TestThreads.TestStartWorkerThread ‑ test_start_worker_thread_returns_a_func_thread
tests.unit.utils.test_threads.TestThreads.TestStartWorkerThread ‑ test_start_worker_thread_with_custom_name

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results - Alternative Providers

206 tests   178 ✅  2m 13s ⏱️
  1 suites   28 💤
  1 files      0 ❌

Results for commit 276cd15.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +10s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 276cd15. ± Comparison against base commit 582c9e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 30m 11s ⏱️
3 149 tests 2 987 ✅ 162 💤 0 ❌
3 163 runs  2 995 ✅ 168 💤 0 ❌

Results for commit 276cd15.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 5m 29s ⏱️ - 56m 2s
3 130 tests  - 2 048  2 965 ✅  - 1 825  165 💤  - 223  0 ❌ ±0 
3 133 runs   - 2 047  2 966 ✅  - 1 824  167 💤  - 223  0 ❌ ±0 

Results for commit 276cd15. ± Comparison against base commit 582c9e8.

This pull request removes 2049 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sns.test_sns.TestSNSPublishCrud ‑ test_publish_no_confirm_subscription
This pull request removes 224 skipped tests and adds 1 skipped test. Note that renamed tests count towards both. 
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input4-FAILED]
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_deployed_infra_state
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_populate_data
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_user_clicks_are_stored
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_api_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_invalid_desiredstate
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_double_create_with_client_token
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_lifecycle
…

tests.aws.services.sns.test_sns.TestSNSPublishCrud ‑ test_publish_no_confirm_subscription

♻️ This comment has been updated with latest results.

@baermat baermat marked this pull request as ready for review February 2, 2026 09:13
@baermat baermat requested a review from bentsku as a code owner February 2, 2026 09:13
bentsku
bentsku reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! It seems there are testing leftovers, but once removed this is good to be merged 👍

tests/aws/services/sns/test_sns.py Outdated
Comment on lines +3917 to +3918
# e_mail = "test@example.com"
e_mail = "bernhard.matyas@localstack.cloud"
Copy link
Contributor

@bentsku bentsku Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: leftover testing values

Copy link
Member Author

@baermat baermat Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

tests/aws/services/sns/test_sns.validation.json Outdated
Comment on lines +584 to +592
"tests/aws/services/sns/test_sns.py::TestSNSPublishCrud::test_publish_confirm_subscription": {
"last_validated_date": "2026-01-29T13:08:16+00:00",
"durations_in_seconds": {
"setup": 1.62,
"call": 138.99,
"teardown": 1.29,
"total": 141.9
}
},
Copy link
Contributor

@bentsku bentsku Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this seems to be a leftover, no test is named that way?

@baermat baermat requested a review from bentsku February 3, 2026 08:07
bentsku
bentsku approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments! 🚀 pushing parity to the limits 😄

@baermat baermat merged commit c3aec4d into main Feb 3, 2026
43 checks passed
@baermat baermat deleted the sns/list-subs-pending branch February 3, 2026 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bentsku bentsku bentsku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baermat @bentsku
X Tutup