Lambda: validate supported runtimes for managed instances#13656
Lambda: validate supported runtimes for managed instances#13656anisaoshafi merged 2 commits intomainfrom
Conversation
anisaoshafi
added
aws:lambda
Test Results - Preflight, Unit23 084 tests ±0 21 225 ✅ ±0 6m 38s ⏱️ -1s Results for commit d769b53. ± Comparison against base commit 44d1022. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 58m 10s ⏱️ +38s For more details on these failures, see this check. Results for commit d769b53. ± Comparison against base commit 44d1022. ♻️ This comment has been updated with latest results. |
anisaoshafi
requested review from
dfangl,
dominikschubert,
gregfurman and
joe4dev
as code owners
joe4dev
left a comment
joe4dev
left a comment
There was a problem hiding this comment.
LGTM.
Added some comments for minor suggestions.
| CodeSigningConfigArn: str | None = None, | ||
| Architectures: Sequence["ArchitectureType"] | None = None, | ||
| EphemeralStorage: Optional["EphemeralStorageTypeDef"] = None, | ||
| CapacityProviderConfig: Optional["CapacityProviderConfigTypeDef"] = None, |
There was a problem hiding this comment.
praise: Thanks for adding these typedefs ✨
|
CI failures are on two flaky SNS tests, which didn't recover on rerun. Merging. |
2 participants
Motivation
Validate supported runtimes for lambda managed instances.
Changes
Validate allowed runtimes on function creation.
Changed waiter in the
create_functionin ParametrizedLambdaself.lambda_client.get_waiter("function_active_v2").wait()-->_is_not_pending().This check doesn't work for
multiruntime_lambdafixture which is reused for managed instances.The status for a lambda managed instance function becomes
ActiveNonInvocable, instead ofActive(which the "function_active_v2" expects), so new approach is to check if status is not pending.Tests
Related