IaC: fix problematic CFN plugin manager import#13621
Conversation
k-a-il
added
semver: minor
k-a-il
changed the title
k-a-il
changed the title
There was a problem hiding this comment.
LGTM! Thanks for jumping on this!
We'll need to think more thoroughly about the upstream resources as well with this, and maybe deferring this import even further by making this a cached property instead of a static method we call once. But this can be a follow-up, let's unblock ourselves for now!
edit: there's also the issue of importing service code outside of the service itself, but we can think about that later. If we only have CloudFormation calling this code, then it would be fine. More argument towards deferring the import until CloudFormation itself calls this code/makes use of it 👍
Thank you and @dfangl for identifying the issue!
Good point, will follow-up on this 👍 |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 35m 36s ⏱️ Results for commit 10695c5. |
3 participants
Motivation
The PR #13597 introduced changes which caused side-effects in another repository. This PR fixes problematic import by moving it to function level.
Changes
Relates to FLC-80