X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Revert IaC: add custom error messages based on service availability#13620

Closed
k-a-il wants to merge 1 commit intomainfrom
flc-80-revert-catalog-integration
Closed

Revert IaC: add custom error messages based on service availability#13620
k-a-il wants to merge 1 commit intomainfrom
flc-80-revert-catalog-integration

Conversation

@k-a-il
Copy link
Collaborator

@k-a-il k-a-il commented Jan 14, 2026

Motivation

The PR #13597 introduced changes which caused side-effects in another repository. This PR reverts changes introduced in the PR and reverts commit 7517af48d4ae. Once the issue is fixed, the PR with this changes will be re-opened

Changes

Reverts commit 7517af48d4ae, which reverts changes introduced in PR #13597.

Relates to FLC-80

@k-a-il k-a-il self-assigned this Jan 14, 2026
@k-a-il k-a-il added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 14, 2026
@k-a-il k-a-il requested a review from bentsku January 14, 2026 17:53
@k-a-il k-a-il marked this pull request as ready for review January 14, 2026 17:53
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0      2 suites  ±0   9m 4s ⏱️ +26s
  552 tests ±0    500 ✅ ±0   52 💤 ±0  0 ❌ ±0 
1 104 runs  ±0  1 000 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 1ff1d1a. ± Comparison against base commit 7517af4.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Test Results - Preflight, Unit

23 070 tests  +1   21 225 ✅ +1   6m 19s ⏱️ - 1m 14s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1ff1d1a. ± Comparison against base commit 7517af4.

This pull request removes 5 and adds 6 tests. Note that renamed tests count towards both. 
tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error_uses_catalog_when_message_is_empty[AVAILABLE_WITH_LICENSE_UPGRADE-is not supported with your LocalStack license]
tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error_uses_catalog_when_message_is_empty[None-The API for service opensearch is either not included in your current license plan or has not yet been emulated by LocalStack.]
tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error_with_custom_message
tests.unit.aws.test_skeleton ‑ test_skeleton_e2e_sqs_send_message_not_implemented[api_class0-NOT_IMPLEMENTED-Sorry, the SendMessage operation on the sqs service is not currently supported by LocalStack.]
tests.unit.aws.test_skeleton ‑ test_skeleton_e2e_sqs_send_message_not_implemented[api_class1-NOT_IMPLEMENTED-We will implement it soon, that's a promise!]

tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error[-not available in your current license plan or has not yet been emulated]
tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error[Ups!-Ups!]
tests.unit.aws.test_skeleton ‑ test_skeleton_e2e_sqs_send_message_not_implemented[api_class0-The API action 'SendMessage' for service 'sqs' is either not available in your current license plan or has not yet been emulated by LocalStack. Please refer to https://docs.localstack.cloud/references/coverage/coverage_sqs for more information.]
tests.unit.aws.test_skeleton ‑ test_skeleton_e2e_sqs_send_message_not_implemented[api_class1-We will implement it soon, that's a promise!]
tests.unit.utils.test_coverage_docs ‑ test_coverage_link_for_existing_service
tests.unit.utils.test_coverage_docs ‑ test_coverage_link_for_non_existing_service

bentsku
bentsku approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for jumping on this! Quite the tricky issue

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 57s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1ff1d1a. ± Comparison against base commit 7517af4.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 37m 33s ⏱️
5 590 tests 5 022 ✅ 568 💤 0 ❌
5 596 runs  5 022 ✅ 574 💤 0 ❌

Results for commit 1ff1d1a.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 56m 28s ⏱️ + 1m 18s
5 169 tests ±0  4 771 ✅ ±0  398 💤 ±0  0 ❌ ±0 
5 171 runs  ±0  4 771 ✅ ±0  400 💤 ±0  0 ❌ ±0 

Results for commit 1ff1d1a. ± Comparison against base commit 7517af4.

@k-a-il k-a-il closed this Jan 14, 2026
@k-a-il
Copy link
Collaborator Author

k-a-il commented Jan 14, 2026

The issue was identified and addressed in #13621

@k-a-il k-a-il deleted the flc-80-revert-catalog-integration branch February 17, 2026 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silv-io silv-io Awaiting requested review from silv-io

1 more reviewer

@bentsku bentsku bentsku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@k-a-il k-a-il

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k-a-il @bentsku
X Tutup