X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix CloudWatch model annotation#13545

Merged
giograno merged 1 commit intomainfrom
cloudwatch-types
Dec 18, 2025
Merged

Fix CloudWatch model annotation#13545
giograno merged 1 commit intomainfrom
cloudwatch-types

Conversation

@giograno
Copy link
Member

@giograno giograno commented Dec 18, 2025 •
edited
Loading

Motivation

This is a follow-up of #13511.
I made a mistake while adding the proper annotation to histories.

Changes

  • Fix the type hint

@giograno
Fix CloudWatch model annotation
7dd32ab 
This is a follow up of
#13511.

I made a mistake while adding the proper annotation to `histories`.
@giograno giograno added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 18, 2025
@giograno giograno self-assigned this Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 37s ⏱️ +35s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7dd32ab. ± Comparison against base commit b613fb9.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 4s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7dd32ab. ± Comparison against base commit b613fb9.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results - Alternative Providers

180 tests    39 ✅  2m 29s ⏱️
  1 suites  141 💤
  1 files      0 ❌

Results for commit 7dd32ab.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 2m 9s ⏱️
1 250 tests 1 174 ✅ 76 💤 0 ❌
1 256 runs  1 174 ✅ 82 💤 0 ❌

Results for commit 7dd32ab.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   46m 20s ⏱️ - 1h 8m 45s
1 226 tests  - 3 927  1 148 ✅  - 3 608  78 💤  - 319  0 ❌ ±0 
1 228 runs   - 3 927  1 148 ✅  - 3 608  80 💤  - 319  0 ❌ ±0 

Results for commit 7dd32ab. ± Comparison against base commit b613fb9.

This pull request removes 3927 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@giograno giograno marked this pull request as ready for review December 18, 2025 16:02
@giograno giograno requested a review from bentsku December 18, 2025 17:27
bentsku
bentsku approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

@giograno giograno merged commit 4a4d4cf into main Dec 18, 2025
58 checks passed
@giograno giograno deleted the cloudwatch-types branch December 18, 2025 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pinzon pinzon Awaiting requested review from pinzon

@steffyP steffyP Awaiting requested review from steffyP

1 more reviewer

@bentsku bentsku bentsku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giograno giograno

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno @bentsku
X Tutup