This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
Test passes just fine as roleArn became optional. Also, test runs way faster against AWS now because the majority of time was spent in role creation.
Hack to check if basic test state scenario works well in LocalStack without a real role. Pending comment about a hack and a validation for states where dummy role cannot be used.
When state is Task and mock is not supplied
Faster execution with only necessary fields provided. Snapshot recording hasn't changed.
tiurin
added
aws:stepfunctions
tiurin
commented
Dec 3, 2025
| sfn_snapshot.match("test_case_response", test_case_response) | ||
|
|
||
| @markers.aws.validated | ||
| def test_base_lambda_service_task_state_no_role_arn_validation( |
Contributor
Author
There was a problem hiding this comment.
Test for the case when roleArn is actually needed.
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 22m 32s ⏱️ - 1h 40m 51s Results for commit 9760b97. ± Comparison against base commit 049201f. This pull request removes 3401 and adds 1 tests. Note that renamed tests count towards both. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 39m 10s ⏱️ Results for commit 9760b97. |
tiurin
added
the
review: merge when ready
gregfurman
approved these changes
Dec 3, 2025
Contributor
gregfurman
left a comment
gregfurman
left a comment
There was a problem hiding this comment.
Looks fine to unblock us 👍
| arn = stepfunctions_state_machine_arn( | ||
| name=name, account_id=context.account_id, region_name=context.region | ||
| ) | ||
| role_arn = request.get("roleArn") |
Contributor
There was a problem hiding this comment.
Do you know if the roleArn param requires any special validations?
Contributor
Author
There was a problem hiding this comment.
I plan to investigate it later, also noticed the lack of validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
roleArnis now only required when tested state is Task and a mock is not provided.Closes DRG-238.
Changes
Add validation for
roleArnpresence.Add workaround for
roleArnbeing not optional in Execution hierarchy.Remove roleArn from tests where it is not needed - much faster execution agaisnt AWS with only necessary fields provided. Snapshot recording hasn't changed.
Tests
Related