X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Change one of the test domains for the DNS tests#13333

Merged
dfangl merged 1 commit intomainfrom
dns/change-test-domain
Nov 4, 2025
Merged

Change one of the test domains for the DNS tests#13333
dfangl merged 1 commit intomainfrom
dns/change-test-domain

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Nov 4, 2025 •
edited
Loading

Motivation

Recent test failures showed the foo.something.org domain we used for testing resolving to an unexpected IP address. It seems the domain owner, a domain reseller, started resolving this domain to some IP.

Even though this seems to have changed again since, we should not take the risk in the future.

Fixes ENG-104

Changes

  • Change something.org to example.org in tests querying the name servers of a domain.

Tests

Related

@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 4, 2025
@dfangl dfangl requested a review from simonrw November 4, 2025 09:51
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

LocalStack Community integration with Pro

2 files  ±    0  2 suites  ±0   33s ⏱️ - 1h 58m 33s
2 tests  - 4 892  0 ✅  - 4 524  2 💤  - 367  0 ❌  - 1 
4 runs   - 4 892  0 ✅  - 4 524  4 💤  - 367  0 ❌  - 1 

Results for commit 6515127. ± Comparison against base commit 4952b82.

This pull request removes 4892 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Test Results - Preflight, Unit

22 278 tests  ±0   20 526 ✅ +1   16m 5s ⏱️ +42s
     1 suites ±0    1 752 💤 ±0 
     1 files   ±0        0 ❌  - 1 

Results for commit 6515127. ± Comparison against base commit 4952b82.

simonrw
simonrw approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, thanks. A ticking time bomb that went off!

There are other mentions of something.org in test_dns_server_soa_record_suffix_matching, is it worth changing those to use example.org as well?

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6515127. ± Comparison against base commit 4952b82.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Test Results (amd64) - Integration, Bootstrap

 5 files   5 suites   9m 22s ⏱️
26 tests 24 ✅ 2 💤 0 ❌
32 runs  24 ✅ 8 💤 0 ❌

Results for commit 6515127.

@dfangl
Copy link
Member Author

dfangl commented Nov 4, 2025

There are other mentions of something.org in test_dns_server_soa_record_suffix_matching, is it worth changing those to use example.org as well?

I saw those, but they are only the value of the SOA entry, not the name queried, so I did not change it. It should not come into contact with the something.org nameservers, so I think we should be safe 👍

@dfangl dfangl merged commit 3262ccd into main Nov 4, 2025
56 checks passed
@dfangl dfangl deleted the dns/change-test-domain branch November 4, 2025 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@simonrw simonrw simonrw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfangl @simonrw
X Tutup